Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 11 Jan 2023 05:50:32 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] nvme: Handle shut down controllers during initialization |
| |
On Wed, Jan 11, 2023 at 01:36:14PM +0900, Hector Martin wrote: > According to the spec, controllers need an explicit reset to become > active again after a controller shutdown. Check for this state in > nvme_enable_ctrl and issue an explicit disable if required, which will > trigger the required reset.
I don't think this belongs into nvme_enable_ctrl. It seems like nvme-apple is missing the equivalent to the nvme_disable_ctrl call in nvme_pci_configure_admin_queue, though.
| ![\](/images/icornerr.gif) |