lkml.org 
[lkml]   [2023]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 03/18] ntfs: Undeprecate iocharset= mount option
On Sunday 01 January 2023 21:02:46 Kari Argillander wrote:
> 26.12.2022 klo 16.22 Pali Rohár (pali@kernel.org) wrote:
> >
> > Other fs drivers are using iocharset= mount option for specifying charset.
> > So mark iocharset= mount option as preferred and deprecate nls= mount
> > option.
>
> snip.
>
> > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
>
> snip.
>
> > @@ -218,10 +213,10 @@ static bool parse_options(ntfs_volume *vol, char *opt)
> > } else if (!strcmp(p, "utf8")) {
> > bool val = false;
> > ntfs_warning(vol->sb, "Option utf8 is no longer "
> > - "supported, using option nls=utf8. Please "
> > - "use option nls=utf8 in the future and "
> > - "make sure utf8 is compiled either as a "
> > - "module or into the kernel.");
> > + "supported, using option iocharset=utf8. "
> > + "Please use option iocharset=utf8 in the "
> > + "future and make sure utf8 is compiled "
> > + "either as a module or into the kernel.");
>
> We do not have to make sure utf8 is compiled anymore as it "always is" right?

Yes, right, we have always utf8 support compiled-in.
Second part of that warning message should be dropped.

> > if (!v || !*v)
> > val = true;
> > else if (!simple_getbool(v, &val))

\
 
 \ /
  Last update: 2023-03-26 23:24    [W:0.103 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site