lkml.org 
[lkml]   [2022]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 13/13] dt-bindings: serial: atmel,at91-usart: Add gclk as a possible USART clock
    From
    On 06/09/2022 15:55, Sergiu Moga wrote:
    > The Devicetree nodes for FLEXCOM's USART can also have an alternative
    > clock source for the baudrate generator (other than the peripheral
    > clock), namely the Generick Clock. Thus make the binding aware of
    > this potential clock that someone may place in the clock related
    > properties of the USART node.

    Last sentence is confusing - what is the potential? Just skip it.

    >
    > Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
    > ---
    >
    >
    >
    > v1 -> v2:
    > - Nothing, this patch was not here before

    You have confusing order of patches. Bindings mixed with DTS mixed with
    drivers. Keep things ordered.
    1. DTS changes needed for aligning to schema.
    2. all bindings
    3. rest

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-09-08 14:37    [W:3.592 / U:0.852 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site