lkml.org 
[lkml]   [2022]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: gadget: rndis: Avoid dereference before NULL check
From
Date
On 9/8/22 8:56 PM, Jim Lin wrote:

> NULL check is performed after params->dev is dereferenced in
> dev_get_stats.
> Fixed by adding a NULL check before dereferencing params->dev and
> removing subsequent NULL checks for it.

You've beaten me to send such a patch... :-)

>
> Signed-off-by: Aniruddha TVS Rao <anrao@nvidia.com>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> drivers/usb/gadget/function/rndis.c | 37 ++++++++++++-----------------
> 1 file changed, 15 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> index 64de9f1b874c..d2f18f34c8e5 100644
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -198,6 +198,9 @@ static int gen_ndis_query_resp(struct rndis_params *params, u32 OID, u8 *buf,
> outbuf = (__le32 *)&resp[1];
> resp->InformationBufferOffset = cpu_to_le32(16);
>
> + if (!params->dev)
> + return -ENODEV;
> +

Hm, isn't this checked at the start of rndis_query_response(), this function's
only caller?

[...]

MBR, Sergey

\
 
 \ /
  Last update: 2022-09-08 22:31    [W:1.577 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site