lkml.org 
[lkml]   [2022]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: x86/mmu: add missing update to max_mmu_rmap_size
On Wed, Sep 07, 2022, Miaohe Lin wrote:
> The update to statistic max_mmu_rmap_size is unintentionally removed by
> commit 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check
> in mmu_set_spte"). Add missing update to it or max_mmu_rmap_size will
> always be nonsensical 0.
>
> Fixes: 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check in mmu_set_spte")

For anyone else wondering "how did so many reviewers miss this obvious bug?", the
answer is that the reviews were collected for v3 and earlier, and the mishandled
merge conflict only showed up in v4.

> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>


Paolo, do you want to grab this for 6.0?

\
 
 \ /
  Last update: 2022-09-07 16:29    [W:0.042 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site