Messages in this thread | | | Date | Wed, 7 Sep 2022 06:08:04 -0700 | Subject | Re: [PATCH] kernel: export task_work_add | From | Bart Van Assche <> |
| |
On 8/28/22 21:00, Ming Lei wrote: > Firstly task_work_add() is used in several drivers. In ublk driver's > usage, request batching submission can only be applied with task_work_add, > and usually get better IOPS. > > Secondly from this API's definition, the added work is always run in > the task context, and when task is exiting, either the work is rejected > to be added, or drained in do_exit(). In this way, not see obvious > disadvantage or potential issue by exporting it for module's usage. > > So export it, then ublk driver can get simplified, meantime with better > performance.
If task_work_add() is exported, shouldn't task_work_cancel() be exported too? Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |