Messages in this thread | | | Date | Wed, 7 Sep 2022 12:54:57 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [PATCH v3 0/4] tty: TX helpers |
| |
On Tue, 6 Sep 2022, Jiri Slaby wrote:
> This series introduces DEFINE_UART_PORT_TX_HELPER + > DEFINE_UART_PORT_TX_HELPER_LIMITED TX helpers. See PATCH 2/4 for the > details. Comments welcome. > > Then it switches drivers to use them. First, to > DEFINE_UART_PORT_TX_HELPER() in 3/4 and then > DEFINE_UART_PORT_TX_HELPER_LIMITED() in 4/4. > > The diffstat of patches 3+4 is as follows: > 26 files changed, 191 insertions(+), 823 deletions(-) > which appears to be nice. > > Cc: Tobias Klauser <tklauser@distanz.ch> > Cc: Richard Genoud <richard.genoud@gmail.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: "Andreas Färber" <afaerber@suse.de> > Cc: Manivannan Sadhasivam <mani@kernel.org> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Kevin Cernekee <cernekee@gmail.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: linux-riscv@lists.infradead.org > > Jiri Slaby (4): > tty: serial: move and cleanup vt8500_tx_empty() > tty: serial: introduce transmit helper generators > tty: serial: use DEFINE_UART_PORT_TX_HELPER() > tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED() > > Documentation/driver-api/serial/driver.rst | 3 + > drivers/tty/serial/21285.c | 33 ++------- > drivers/tty/serial/altera_jtaguart.c | 42 +++-------- > drivers/tty/serial/altera_uart.c | 37 ++-------- > drivers/tty/serial/amba-pl010.c | 37 ++-------- > drivers/tty/serial/apbuart.c | 36 ++-------- > drivers/tty/serial/atmel_serial.c | 29 ++------ > drivers/tty/serial/bcm63xx_uart.c | 47 +++---------- > drivers/tty/serial/fsl_lpuart.c | 38 +++------- > drivers/tty/serial/lantiq.c | 44 ++++-------- > drivers/tty/serial/lpc32xx_hs.c | 38 ++-------- > drivers/tty/serial/mcf.c | 27 ++------ > drivers/tty/serial/mpc52xx_uart.c | 43 +----------- > drivers/tty/serial/mps2-uart.c | 29 +------- > drivers/tty/serial/mux.c | 46 ++++-------- > drivers/tty/serial/mvebu-uart.c | 40 ++--------- > drivers/tty/serial/mxs-auart.c | 31 ++------- > drivers/tty/serial/omap-serial.c | 47 ++++--------- > drivers/tty/serial/owl-uart.c | 35 +--------- > drivers/tty/serial/pxa.c | 39 +++-------- > drivers/tty/serial/rp2.c | 36 ++-------- > drivers/tty/serial/sa1100.c | 49 +++++-------- > drivers/tty/serial/serial_txx9.c | 37 ++-------- > drivers/tty/serial/sifive.c | 45 ++---------- > drivers/tty/serial/sprd_serial.c | 38 ++-------- > drivers/tty/serial/st-asc.c | 50 ++----------- > drivers/tty/serial/vt8500_serial.c | 40 ++--------- > include/linux/serial_core.h | 81 ++++++++++++++++++++++ > 28 files changed, 275 insertions(+), 822 deletions(-)
For the whole series:
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i.
| |