lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 21/80] serial: fsl_lpuart: RS485 RTS polariy is inverse
    Date
    From: Shenwei Wang <shenwei.wang@nxp.com>

    commit 846651eca073e2e02e37490a4a52752415d84781 upstream.

    The setting of RS485 RTS polarity is inverse in the current driver.

    When the property of 'rs485-rts-active-low' is enabled in the dts node,
    the RTS signal should be LOW during sending. Otherwise, if there is no
    such a property, the RTS should be HIGH during sending.

    Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485")
    Cc: stable <stable@kernel.org>
    Signed-off-by: Nicolas Diaz <nicolas.diaz@nxp.com>
    Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
    Link: https://lore.kernel.org/r/20220805144529.604856-1-shenwei.wang@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/serial/fsl_lpuart.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/tty/serial/fsl_lpuart.c
    +++ b/drivers/tty/serial/fsl_lpuart.c
    @@ -1376,9 +1376,9 @@ static int lpuart32_config_rs485(struct
    * Note: UART is assumed to be active high.
    */
    if (rs485->flags & SER_RS485_RTS_ON_SEND)
    - modem &= ~UARTMODEM_TXRTSPOL;
    - else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
    modem |= UARTMODEM_TXRTSPOL;
    + else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
    + modem &= ~UARTMODEM_TXRTSPOL;
    }

    /* Store the new configuration */

    \
     
     \ /
      Last update: 2022-09-06 15:38    [W:5.718 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site