lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 1/3] iio: temperature: mlx90632 Add runtime powermanagement modes
On Tue, 6 Sept 2022 at 14:37, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Tue, Sep 6, 2022 at 1:52 PM Crt Mori <cmo@melexis.com> wrote:
> > On Tue, 6 Sept 2022 at 12:21, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > >
> > > Very good and documented code, thanks!
> > > I believe you better to use DEFINE_.*_PM_OPS instead of legacy ones
> > > (due to pm_ptr() usage).
> > > Otherwise, with some nitpicks that wouldn't prevent a green light,
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >
> > I checked DEFINE_.*_PM_OPS usage around drivers and you either have
> > SIMPLE (where you define suspend/resume) or you have RUNTIME (for
> > runtime suspend/resume), but never are those two together. So I am a
> > bit puzzled how to get this working.
>
> The one which suits here is called _DEFINE_DEV_PM_OPS(). But it's
> basically the same what you put here with the possible unused case.
>
I thought underscore prefixed macros are the ones not to be used
directly by drivers. I also found no occurrence in current drivers, so
it was not something that was done so far?

\
 
 \ /
  Last update: 2022-09-06 15:05    [W:0.090 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site