Messages in this thread | | | From | Huacai Chen <> | Date | Tue, 6 Sep 2022 13:57:31 +0800 | Subject | Re: [PATCH v7 0/5] LoongArch: Support toolchain with new relocation types |
| |
Hi, Ruoyao,
On Tue, Sep 6, 2022 at 1:01 PM Xi Ruoyao <xry111@xry111.site> wrote: > > On Tue, 2022-09-06 at 12:43 +0800, Huacai Chen wrote: > > > Note that -fpic/-fPIC is "position-independent code *suitable for > > > use in a shared library*", while -fpie/-fPIE is more like just > > > "position-independent code". The names of those options are confusing. > > > (When -fpic was invented first time, people mostly believed "PIC had > > > been only for shared libraries", so it's named -fpic instead of -shlib > > > or something.) IMO in the EFI stub for other ports, -fpie should be > > > used instead of -fpic as well because the EFI stub is not similar to a > > > shared library in any means. > > > You are right, but I guess that Ard doesn't want to squash the efistub > > change into the LoongArch efistub support patch. :) > > It only changes cflags-$(CONFIG_LOONGARCH), which is LoongArch specific. > And arm64 is also using -fpie. > > Should I send the one-line EFI stub change to linux-efi first? I know that should be changed. I just don't like the one-line patch and hope it can be squashed to the original patch. Of course Ard is free to decide how to handle it.
Huacai > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University
| |