Messages in this thread | | | From | "Gupta, Nipun" <> | Subject | RE: [RFC PATCH v2 1/6] Documentation: DT: Add entry for CDX controller | Date | Tue, 6 Sep 2022 07:03:07 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, September 6, 2022 12:25 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; gregkh@linuxfoundation.org; > rafael@kernel.org; eric.auger@redhat.com; alex.williamson@redhat.com; > cohuck@redhat.com; Gupta, Puneet (DCG-ENG) > <puneet.gupta@amd.com>; song.bao.hua@hisilicon.com; > mchehab+huawei@kernel.org; maz@kernel.org; f.fainelli@gmail.com; > jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > kvm@vger.kernel.org > Cc: okaya@kernel.org; Anand, Harpreet <harpreet.anand@amd.com>; > Agarwal, Nikhil <nikhil.agarwal@amd.com>; Simek, Michal > <michal.simek@amd.com>; git (AMD-Xilinx) <git@amd.com> > Subject: Re: [RFC PATCH v2 1/6] Documentation: DT: Add entry for CDX > controller > > [CAUTION: External Email] > > On 05/09/2022 16:05, Gupta, Nipun wrote: > >>> + > >>> + cdxbus: cdxbus@@4000000 { > >> > >> Node names should be generic, so "cdx" > > > > Would be using bus: cdxbus@4000000. > > Kindly correct me if this does not seem to be correct. > > I don't understand it. I asked to change cdxbus to cdx, but you said you > will be using "bus" and "cdxbus"? So what exactly are you going to use? > And how does it match generic node name recommendation?
I was also confused with the name suggestion as in one of the mail you sent out later, you mentioned: " Eh, too fast typing, obviously the other part of the name... node names should be generic, so just "bus"."
That is why needed to confirm. To me now "cdx: cdx@4000000" makes sense. Hope this seems correct?
Regards, Nipun
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevi > cetree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2- > devicetree-basics.html%23generic-names- > recommendation&data=05%7C01%7CNipun.Gupta%40amd.com%7C4a > e1b96c542949574f3a08da8fd4c64d%7C3dd8961fe4884e608e11a82d994e183d > %7C0%7C0%7C637980441269905225%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7C%7C%7C&sdata=pA0kWXNJGQw9y5zLNNXpfRMjH1i2QRM%2FK > YsNk0C%2FCQM%3D&reserved=0 > > Do you see any other buses named "xxxbus"? > > Best regards, > Krzysztof
| |