Messages in this thread | | | Date | Tue, 6 Sep 2022 07:00:22 +1000 | From | Tom Fitzhenry <> | Subject | Re: [PATCH v5 0/1] Add support for the Pine64 PinePhone Pro phone |
| |
On 5/9/22 03:22, Heiko Stuebner wrote: > On Mon, 29 Aug 2022 15:00:39 +1000, Tom Fitzhenry wrote: >> PinePhone Pro is a RK3399 based phone produced by Pine64. >> >> Add a basic DTS for it. This is a working base that will allow myself and >> others to add more nodes. >> >> Relies on "dt-bindings: arm: rockchip: Add PinePhone Pro bindings"[0]. >> >> [...] > > Applied, thanks! > > [1/1] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro > commit: 78a21c7d59520e72ebea667fe8745a4371d9fe86 > > > Why was the dt-binding addition missing? > I've pulled the binding from v3 now. > > While it is true that you should not resend patches just to add Acks, > when re-sending a whole series that includes other changes it's still > necessary to keep all patches together ;-)
Ah, I had misinterpreted previous advice on when it was necessary to repost patches.
I did wonder how maintainers would then discover the set of patches, and so included the "Relies on [..." text above.
I will ensure patch series are complete in future.
Thanks for your patience and review! :)
| |