Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 30 Sep 2022 09:25:40 -0700 | Subject | Re: [PATCH v5 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker |
| |
Hi,
On Fri, Sep 30, 2022 at 12:38 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > Change touchpad and touchscreen node for evoker > Touchpad: SA461D-1011 > Touchscreen: GT7986U
[...cut...]
> + touchscreen: touchscreen@5d { > + compatible = "goodix,gt7375p"; > + reg = <0x5d>;
One further note is that in the commit message you've said GT7986U in the commit message but you're specifying "goodix,gt7375p" here. Ideally, what you'd do is:
1. Create a bindings patch modifying "goodix,gt7375p.yaml" much like we did for elan [1]. You'd end up with something like this (untested):
compatible: oneOf: - const: goodix,gt7375p - items: - const: goodix,gt7986u - const: goodix,gt7375p
2. You wouldn't need any driver patch unless the timings for gt7986u are different than gt7375p
3. In your device tree, you'd list:
compatible = "goodix,gt7986u", "goodix,gt7375p";
...which says "I really have a gt7986u, but if you don't have any special knowledge about gt7986u then you can just pretend I have a gt7375p".
[1] https://lore.kernel.org/r/20220923083657.v5.2.Ic4e8f03868f88b8027a81bc3d414bae68978e6b7@changeid
| |