Messages in this thread | | | From | Miles Chen <> | Subject | Re: [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function | Date | Fri, 30 Sep 2022 15:09:24 +0800 |
| |
>On Wed, Sep 28, 2022 at 9:55 AM Miles Chen <miles.chen@mediatek.com> wrote: >> >> >> top_early_divs are registered in the CLK_OF_DECLARE_DRIVER() half of the >> >> topckgen clk driver. Don't try to register it again in the actual probe >> >> function. This gets rid of the "Trying to register duplicate clock ..." >> >> warning. >> >> >> >> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> >> > >> >Can't we simply remove the CLK_OF_DECLARE_DRIVER() and top_init_early entirely, >> >and transfer TOP_CSW_F26M_D2 to top_divs[] instead? >> >I get that systimer concern and we have something similar in MT8195, where the >> >TOP_CLK26M_D2 is registered "late". >> >> Another reason for this: >> Removing the CLK_OF_DECLARE_DRIVER() is good when we want to build our driver as >> kernel modules because it does not work with kernel modules. > >I agree. But as I mentioned in my other reply, we need to fix the clock >user first before dropping that clock. And there's also the matter of >DT backward compatibility. So we need to do it incrementally. > > >ChenYu
Got it. thanks for doing this.
thanks, Miles
| |