Messages in this thread | | | From | David Laight <> | Subject | RE: amusing SLUB compaction bug when CC_OPTIMIZE_FOR_SIZE | Date | Thu, 29 Sep 2022 11:53:17 +0000 |
| |
> -static void rcu_free_slab(struct rcu_head *h) > +/* > + * rcu_free_slab() must be __aligned(4) because its address is saved > + * in the rcu_head field, which coincides with page->mapping, which > + * causes trouble if compaction mistakes it for PAGE_MAPPING_MOVABLE. > + */ > +__aligned(4) static void rcu_free_slab(struct rcu_head *h) > { > struct slab *slab = container_of(h, struct slab, rcu_head); >
Isn't that going to cause grief with options that align functions on 16/32byte boundaries when adding space for 'other stuff'?
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |