lkml.org 
[lkml]   [2022]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 8/8] soc: mtk-svs: mt8192: fix bank data
From
Il 28/09/22 17:55, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Values vmax and dvt_fixed are not changed at runtime, set them as needed
> in the svs_banks struct.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>

Honestly, I'm undecided on this one... because the vmax += dvt_fixed is something
descriptive of how the SVS works.
Since you're simply removing one addition, in a path that gets executed only once
in a kernel boot life, that's not even going to improve performance at all...

Right now, I'm more for dropping this change than keeping it.

Cheers,
Angelo

> ---
>
> drivers/soc/mediatek/mt8192-svs.h | 4 ++--
> drivers/soc/mediatek/mtk-svs-mt8192.c | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mt8192-svs.h b/drivers/soc/mediatek/mt8192-svs.h
> index 6571ebcb2c0f..bf8c6030428f 100644
> --- a/drivers/soc/mediatek/mt8192-svs.h
> +++ b/drivers/soc/mediatek/mt8192-svs.h
> @@ -16,7 +16,7 @@ static struct svs_bank svs_mt8192_banks[] = {
> .turn_freq_base = 688000000,
> .volt_step = 6250,
> .volt_base = 400000,
> - .vmax = 0x60,
> + .vmax = 0x61,
> .vmin = 0x1a,
> .age_config = 0x555555,
> .dc_config = 0x1,
> @@ -41,7 +41,7 @@ static struct svs_bank svs_mt8192_banks[] = {
> .turn_freq_base = 688000000,
> .volt_step = 6250,
> .volt_base = 400000,
> - .vmax = 0x60,
> + .vmax = 0x66,
> .vmin = 0x1a,
> .age_config = 0x555555,
> .dc_config = 0x1,
> diff --git a/drivers/soc/mediatek/mtk-svs-mt8192.c b/drivers/soc/mediatek/mtk-svs-mt8192.c
> index 838a94834741..183acf2829f0 100644
> --- a/drivers/soc/mediatek/mtk-svs-mt8192.c
> +++ b/drivers/soc/mediatek/mtk-svs-mt8192.c
> @@ -40,8 +40,6 @@ bool svs_mt8192_efuse_parsing(struct svs_platform *svsp)
> svsb->dcbdet = (svsp->efuse[17] >> 16) & GENMASK(7, 0);
> svsb->dcmdet = (svsp->efuse[17] >> 24) & GENMASK(7, 0);
> }
> -
> - svsb->vmax += svsb->dvt_fixed;
> }
>
> ret = svs_thermal_efuse_get_data(svsp);

\
 
 \ /
  Last update: 2022-09-29 10:27    [W:0.147 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site