Messages in this thread | | | Date | Wed, 28 Sep 2022 17:43:07 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v4 6/7] pwm: lpss: Make use of bits.h macros for all masks |
| |
On Wed, Sep 28, 2022 at 04:20:46PM +0200, Thierry Reding wrote: > On Tue, Sep 27, 2022 at 07:24:20PM +0300, Andy Shevchenko wrote: > > Make use of the GENMASK() (far less error-prone, far more concise). > > Very subjective.
See an example why not: 0a90ed8d0cfa ("platform/x86: pmc_atom: Fix SLP_TYPx bitfield mask").
-- With Best Regards, Andy Shevchenko
| |