lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 05/29] thermal/of: Use generic thermal_zone_get_trip() function
    Date
    The thermal framework gives the possibility to register the trip
    points with the thermal zone. When that is done, no get_trip_* ops are
    needed and they can be removed.

    The thermal OF code uses the thermal_zone_device_register_with_trips()
    function. It builds the trips array and pass it to the register
    function. That means the get_trip_* ops are duplicated with what does
    already the core code.

    Remove them.

    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    ---
    drivers/thermal/thermal_of.c | 36 ------------------------------------
    1 file changed, 36 deletions(-)

    diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
    index d4b6335ace15..5cce83639085 100644
    --- a/drivers/thermal/thermal_of.c
    +++ b/drivers/thermal/thermal_of.c
    @@ -71,39 +71,6 @@ of_thermal_get_trip_points(struct thermal_zone_device *tz)
    }
    EXPORT_SYMBOL_GPL(of_thermal_get_trip_points);

    -static int of_thermal_get_trip_type(struct thermal_zone_device *tz, int trip,
    - enum thermal_trip_type *type)
    -{
    - if (trip >= tz->num_trips || trip < 0)
    - return -EDOM;
    -
    - *type = tz->trips[trip].type;
    -
    - return 0;
    -}
    -
    -static int of_thermal_get_trip_temp(struct thermal_zone_device *tz, int trip,
    - int *temp)
    -{
    - if (trip >= tz->num_trips || trip < 0)
    - return -EDOM;
    -
    - *temp = tz->trips[trip].temperature;
    -
    - return 0;
    -}
    -
    -static int of_thermal_get_trip_hyst(struct thermal_zone_device *tz, int trip,
    - int *hyst)
    -{
    - if (trip >= tz->num_trips || trip < 0)
    - return -EDOM;
    -
    - *hyst = tz->trips[trip].hysteresis;
    -
    - return 0;
    -}
    -
    static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,
    int hyst)
    {
    @@ -626,9 +593,6 @@ struct thermal_zone_device *thermal_of_zone_register(struct device_node *sensor,
    goto out_kfree_trips;
    }

    - of_ops->get_trip_type = of_ops->get_trip_type ? : of_thermal_get_trip_type;
    - of_ops->get_trip_temp = of_ops->get_trip_temp ? : of_thermal_get_trip_temp;
    - of_ops->get_trip_hyst = of_ops->get_trip_hyst ? : of_thermal_get_trip_hyst;
    of_ops->set_trip_hyst = of_ops->set_trip_hyst ? : of_thermal_set_trip_hyst;
    of_ops->get_crit_temp = of_ops->get_crit_temp ? : of_thermal_get_crit_temp;
    of_ops->bind = thermal_of_bind;
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-09-28 23:03    [W:4.124 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site