lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 01/11] dt-bindings: remoteproc: mediatek: Give the subnode a persistent name
From


On 9/27/2022 10:55 AM, Tinghan Shen wrote:
> The node name doesn't matter to add the subnode as a cros-ec rpmsg device.
> Give it a clear persistent node name to simplify scp yaml.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../bindings/remoteproc/mtk,scp.yaml | 35 ++++++++++---------
> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +-
> 2 files changed, 20 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 7e091eaffc18..786bed897916 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -58,6 +58,23 @@ properties:
> memory-region:
> maxItems: 1
>
> + cros-ec-rpmsg:
> + type: object
> + description:
> + This subnode represents the rpmsg device. The names of the devices
> + are not important. The properties of this node are defined by the
> + individual bindings for the rpmsg devices.
> +
> + properties:
> + mediatek,rpmsg-name:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Contains the name for the rpmsg device. Used to match
> + the subnode to rpmsg device announced by SCP.
> +
> + required:
> + - mediatek,rpmsg-name
> +
> required:
> - compatible
> - reg
> @@ -89,21 +106,7 @@ allOf:
> reg-names:
> maxItems: 2
>
> -additionalProperties:
> - type: object
> - description:
> - Subnodes of the SCP represent rpmsg devices. The names of the devices
> - are not important. The properties of these nodes are defined by the
> - individual bindings for the rpmsg devices.
> - properties:
> - mediatek,rpmsg-name:
> - $ref: /schemas/types.yaml#/definitions/string-array
> - description:
> - Contains the name for the rpmsg device. Used to match
> - the subnode to rpmsg device announced by SCP.
> -
> - required:
> - - mediatek,rpmsg-name
> +additionalProperties: false
>
> examples:
> - |
> @@ -118,7 +121,7 @@ examples:
> clocks = <&infracfg CLK_INFRA_SCPSYS>;
> clock-names = "main";
>
> - cros_ec {
> + cros-ec-rpmsg {
> mediatek,rpmsg-name = "cros-ec-rpmsg";
> };
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index b4b86bb1f1a7..693ad5f2a82e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

DTS changes should be in separate patch.

Regards,
Peng.

> @@ -816,7 +816,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&scp_pins>;
>
> - cros_ec {
> + cros-ec-rpmsg {
> compatible = "google,cros-ec-rpmsg";
> mediatek,rpmsg-name = "cros-ec-rpmsg";
> };

\
 
 \ /
  Last update: 2022-09-28 08:56    [W:0.269 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site