lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv4 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"
From
On 28/09/2022 18:54, Dinh Nguyen wrote:
> Document the optional "altr,sysmgr-syscon" binding that is used to
> access the System Manager register that controls the SDMMC clock
> phase.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---

Thank you for your patch. There is something to discuss/improve.

> +
> +allOf:
> + - $ref: "synopsys-dw-mshc-common.yaml#"
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const:
> + - altr,socfpga-dw-mshc

It still should not be an array, even if there is no warning.

> + then:
> + required:
> + - altr,sysmgr-syscon
> + else:
> + properties:
> + altr,sysmgr-syscon: false

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-28 19:17    [W:0.109 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site