Messages in this thread | | | Date | Tue, 27 Sep 2022 08:01:28 -0700 | From | Richard Cochran <> | Subject | Re: [PATCH] ptp: Remove usage of the deprecated ida_simple_xxx API |
| |
On Sun, Sep 25, 2022 at 09:27:44PM -0400, Bo Liu wrote: > Use ida_alloc_xxx()/ida_free() instead of > ida_simple_get()/ida_simple_remove(). > The latter is deprecated and more verbose.
I can't say that I am excited about this. It seems like a way to create a regression. I don't see any need to change. After all, there are many "deprecated" interfaces in use.
> Signed-off-by: Bo Liu <liubo03@inspur.com> > --- > drivers/ptp/ptp_clock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c > index 688cde320bb0..51cae72bb6db 100644 > --- a/drivers/ptp/ptp_clock.c > +++ b/drivers/ptp/ptp_clock.c > @@ -174,7 +174,7 @@ static void ptp_clock_release(struct device *dev) > mutex_destroy(&ptp->tsevq_mux); > mutex_destroy(&ptp->pincfg_mux); > mutex_destroy(&ptp->n_vclocks_mux); > - ida_simple_remove(&ptp_clocks_map, ptp->index); > + ida_free(&ptp_clocks_map, ptp->index); > kfree(ptp); > } > > @@ -217,7 +217,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, > if (ptp == NULL) > goto no_memory; > > - index = ida_simple_get(&ptp_clocks_map, 0, MINORMASK + 1, GFP_KERNEL); > + index = ida_alloc_max(&ptp_clocks_map, MINORMASK, GFP_KERNEL);
Typo? You changed the value of the second argument.
Thanks, Richard
> if (index < 0) { > err = index; > goto no_slot; > @@ -332,7 +332,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, > mutex_destroy(&ptp->tsevq_mux); > mutex_destroy(&ptp->pincfg_mux); > mutex_destroy(&ptp->n_vclocks_mux); > - ida_simple_remove(&ptp_clocks_map, index); > + ida_free(&ptp_clocks_map, index); > no_slot: > kfree(ptp); > no_memory: > -- > 2.27.0 >
| |