Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 27 Sep 2022 15:31:24 +0200 | Subject | Re: [PATCH 5/5] ARM: make ARCH_MULTIPLATFORM user-visible |
| |
Hi Arnd,
On Thu, Aug 18, 2022 at 4:56 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Some options like CONFIG_DEBUG_UNCOMPRESS and CONFIG_CMDLINE_FORCE are > fundamentally incompatible with portable kernels but are currently allowed > in all configurations. Other options like XIP_KERNEL are essentially > useless after the completion of the multiplatform conversion. > > Repurpose the existing CONFIG_ARCH_MULTIPLATFORM option to decide > whether the resulting kernel image is meant to be portable or not, > and using this to guard all of the known incompatible options. > > This is similar to how the RISC-V kernel handles the CONFIG_NONPORTABLE > option (with the opposite polarity). > > A few references to CONFIG_ARCH_MULTIPLATFORM were left behind by > earlier clanups and have to be removed now up. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for your patch!
> --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1904,6 +1904,7 @@ config DEBUG_UART_8250_PALMCHIP > > config DEBUG_UNCOMPRESS > bool "Enable decompressor debugging via DEBUG_LL output" > + depends on !ARCH_MULTIPLATFORM
Shouldn't DEBUG_LL itself depend on !ARCH_MULTIPLATFORM instead?
> depends on !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100) > depends on DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \ > (!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |