lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable
[+Greg]

On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Return the value iproc_pcie_setup_ib() directly instead of storing it in
> > another redundant variable.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
>
> This patch itself is fine, but was posted by cgel.zte@gmail.com, not by
> "ye xingchen <ye.xingchen@zte.com.cn>", so it needs another signoff
> and full name so the chain is complete. For more details see:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363

Greg, Bjorn,

I believe that appending a SoB like this myself is fine:

Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>

It is a SOB already in kernel commit logs - I assume
that's the right thing to do in this case, please
let me know if it isn't and what should we do instead.

Thanks,
Lorenzo

> Bjorn
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2022-09-27 14:08    [W:0.096 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site