lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs
From


On 2022/9/27 22:52, Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 19:54:56 +0800 ruanjinjie wrote:
>> Add missing __init/__exit annotations to module init/exit funcs
>
> How many of these do you have? Do you use a tool to find the cases
> where the annotations can be used?
>
I think Linux kernel drivers have many of these problems.I use grep
command to compare all the driver C files and find where the annotations
can be used.

> Please read Documentation/process/researcher-guidelines.rst
> and make sure you comply with what is expected in the commit message.

Thank you very much! Some key information is missing from the commit
message. Should I update the commit message and resubmit the patch?

\
 
 \ /
  Last update: 2022-09-28 05:14    [W:0.139 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site