lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 104/148] net: sh_eth: Fix PHY state warning splat during system resume
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 6a1dbfefdae4f7809b3e277cc76785dac0ac1cd0 ]

    Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
    mdio_bus_phy_resume() state"), a warning splat is printed during system
    resume with Wake-on-LAN disabled:

    WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4

    As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
    in its suspend/resume callbacks, it is sufficient to just mark the MAC
    responsible for managing the power state of the PHY.

    Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Link: https://lore.kernel.org/r/c6e1331b9bef61225fa4c09db3ba3e2e7214ba2d.1663598886.git.geert+renesas@glider.be
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/renesas/sh_eth.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
    index 1374faa229a2..4e190f5e32c3 100644
    --- a/drivers/net/ethernet/renesas/sh_eth.c
    +++ b/drivers/net/ethernet/renesas/sh_eth.c
    @@ -2033,6 +2033,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
    }
    }

    + /* Indicate that the MAC is responsible for managing PHY PM */
    + phydev->mac_managed_pm = true;
    phy_attached_info(phydev);

    return 0;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 13:25    [W:4.052 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site