lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 064/148] dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit f9fdb0b86f087c2b7f6c6168dd0985a3c1eda87e ]

    We should call of_node_put() for the reference returned by
    of_parse_phandle() in fail path or when it is not used anymore.
    Here we only need to move the of_node_put() before the check.

    Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
    Signed-off-by: Liang He <windhl@126.com>
    Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
    Link: https://lore.kernel.org/r/20220720073234.1255474-1-windhl@126.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/ti/k3-udma-private.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/dma/ti/k3-udma-private.c b/drivers/dma/ti/k3-udma-private.c
    index aada84f40723..3257b2f5157c 100644
    --- a/drivers/dma/ti/k3-udma-private.c
    +++ b/drivers/dma/ti/k3-udma-private.c
    @@ -31,14 +31,14 @@ struct udma_dev *of_xudma_dev_get(struct device_node *np, const char *property)
    }

    pdev = of_find_device_by_node(udma_node);
    + if (np != udma_node)
    + of_node_put(udma_node);
    +
    if (!pdev) {
    pr_debug("UDMA device not found\n");
    return ERR_PTR(-EPROBE_DEFER);
    }

    - if (np != udma_node)
    - of_node_put(udma_node);
    -
    ud = platform_get_drvdata(pdev);
    if (!ud) {
    pr_debug("UDMA has not been probed\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 13:21    [W:8.786 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site