lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 053/141] gpio: mockup: fix NULL pointer dereference when removing debugfs
    Date
    From: Bartosz Golaszewski <brgl@bgdev.pl>

    commit b7df41a6f79dfb18ba2203f8c5f0e9c0b9b57f68 upstream.

    We now remove the device's debugfs entries when unbinding the driver.
    This now causes a NULL-pointer dereference on module exit because the
    platform devices are unregistered *after* the global debugfs directory
    has been recursively removed. Fix it by unregistering the devices first.

    Fixes: 303e6da99429 ("gpio: mockup: remove gpio debugfs when remove device")
    Cc: Wei Yongjun <weiyongjun1@huawei.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpio-mockup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpio/gpio-mockup.c
    +++ b/drivers/gpio/gpio-mockup.c
    @@ -604,9 +604,9 @@ static int __init gpio_mockup_init(void)

    static void __exit gpio_mockup_exit(void)
    {
    + gpio_mockup_unregister_pdevs();
    debugfs_remove_recursive(gpio_mockup_dbg_dir);
    platform_driver_unregister(&gpio_mockup_driver);
    - gpio_mockup_unregister_pdevs();
    }

    module_init(gpio_mockup_init);

    \
     
     \ /
      Last update: 2022-09-26 13:20    [W:4.107 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site