lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 063/141] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob
    Date
    From: Brian Norris <briannorris@chromium.org>

    [ Upstream commit e5467359a725de90b6b8d0dd865500f6373828ca ]

    The Gru-Bob board does not have a pull-up resistor on its
    WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel
    specified the pin configuration correctly as a pull-up, but this didn't
    get ported correctly to upstream.

    This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent
    wakeup behavior.

    Note that bt_host_wake_l has a similar dynamic, but apparently the
    upstream choice was to redundantly configure both internal and external
    pull-up on Kevin (see the "Kevin has an external pull up" comment in
    rk3399-gru.dtsi). This doesn't cause any functional problem, although
    it's perhaps wasteful.

    Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob")
    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Reviewed-by: Douglas Anderson <dianders@chromium.org>
    Link: https://lore.kernel.org/r/20220822164453.1.I75c57b48b0873766ec993bdfb7bc1e63da5a1637@changeid
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 5 +++++
    arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 +
    2 files changed, 6 insertions(+)

    diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts
    index e6c1c94c8d69..07737b65d7a3 100644
    --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts
    +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts
    @@ -87,3 +87,8 @@ h1_int_od_l: h1-int-od-l {
    };
    };
    };
    +
    +&wlan_host_wake_l {
    + /* Kevin has an external pull up, but Bob does not. */
    + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
    +};
    diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    index 1384dabbdf40..0d8458d55626 100644
    --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    @@ -395,6 +395,7 @@ wifi_perst_l: wifi-perst-l {
    };

    wlan_host_wake_l: wlan-host-wake-l {
    + /* Kevin has an external pull up, but Bob does not */
    rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
    };
    };
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 13:01    [W:4.678 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site