Messages in this thread | | | Subject | RE: Re: [RESEND] devfreq: governor: Save void *data in the governor userspace | From | MyungJoo Ham <> | Date | Mon, 26 Sep 2022 18:50:33 +0900 |
| |
> On 9/15/2022 3:41 PM, Kant Fan wrote: > > > > diff --git a/drivers/devfreq/governor_userspace.c > > b/drivers/devfreq/governor_userspace.c > > index ab9db7a..d69672c 100644 > > --- a/drivers/devfreq/governor_userspace.c > > +++ b/drivers/devfreq/governor_userspace.c > > @@ -21,7 +21,7 @@ > > > > static int devfreq_userspace_func(struct devfreq *df, unsigned long > > *freq) > > { > > - struct userspace_data *data = df->data; > > + struct userspace_data *data = df->governor_data; > > > > if (data->valid) > > *freq = data->user_frequency; > > @@ -40,7 +40,7 @@ > > int err = 0; > > > > mutex_lock(&devfreq->lock); > > - data = devfreq->data; > > + data = devfreq->governor_data; > > > > sscanf(buf, "%lu", &wanted); > > data->user_frequency = wanted; > > @@ -60,7 +60,7 @@ > > int err = 0; > > > > mutex_lock(&devfreq->lock); > > - data = devfreq->data; > > + data = devfreq->governor_data; > > > > if (data->valid) > > err = sprintf(buf, "%lu\n", data->user_frequency); > > @@ -91,7 +91,7 @@ > > goto out; > > } > > data->valid = false; > > - devfreq->data = data; > > + devfreq->governor_data = data; > > > > err = sysfs_create_group(&devfreq->dev.kobj, &dev_attr_group); > > out: > > @@ -107,8 +107,8 @@ > > if (devfreq->dev.kobj.sd) > > sysfs_remove_group(&devfreq->dev.kobj, &dev_attr_group); > > > > - kfree(devfreq->data); > > - devfreq->data = NULL; > > + kfree(devfreq->governor_data); > > + devfreq->governor_data = NULL; > > } > > > > static int devfreq_userspace_handler(struct devfreq *devfreq, > > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h > > index 34aab4d..d265af3 100644 > > --- a/include/linux/devfreq.h > > +++ b/include/linux/devfreq.h > > @@ -152,8 +152,8 @@ > > * @max_state: count of entry present in the frequency table. > > * @previous_freq: previously configured frequency value. > > * @last_status: devfreq user device info, performance statistics > > - * @data: Private data of the governor. The devfreq framework does not > > - * touch this. > > + * @data: devfreq core pass to governors, governor should not change > > it. > > + * @governor_data: private data for governors, devfreq core doesn't > > touch it. > > * @user_min_freq_req: PM QoS minimum frequency request from user > > (via sysfs) > > * @user_max_freq_req: PM QoS maximum frequency request from user > > (via sysfs) > > * @scaling_min_freq: Limit minimum frequency requested by OPP > > interface > > @@ -193,7 +193,8 @@ > > unsigned long previous_freq; > > struct devfreq_dev_status last_status; > > > > - void *data; /* private data for governors */ > > + void *data; > > + void *governor_data; > > > > struct dev_pm_qos_request user_min_freq_req; > > struct dev_pm_qos_request user_max_freq_req; > > > > Hi MyungJoo, > Sorry to disturb. Just want to say that I'm looking forward to your > advice on this patch. Thank you :> >
This new code looks good to me. Anyway, Chanwoo, how do you think of this?
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Cheers, MyungJoo.
| |