Messages in this thread | | | From | Vishal Annapurve <> | Date | Mon, 26 Sep 2022 16:40:00 -0700 | Subject | Re: [V2 PATCH 4/8] KVM: selftests: x86: Precompute the result for is_{intel,amd}_cpu() |
| |
On Mon, Sep 26, 2022 at 4:34 PM David Matlack <dmatlack@google.com> wrote: > > On Mon, Sep 26, 2022 at 4:27 PM Vishal Annapurve <vannapurve@google.com> wrote: > > > > On Wed, Sep 21, 2022 at 2:19 PM David Matlack <dmatlack@google.com> wrote: > > > ... > > > > is_amd_cpu is used by guest code within fix_hypercall_test.c, just > > caching the result will break the guest code execution. I have clubbed > > these two changes together in order to ensure that is_amd_cpu works > > fine for both host userspace and guest vm logic. > > Ah, so the sync_global_to_guest() part needs to go in the patch that > adds caching to is_amd_cpu(). > > But the point still stands that adding AMD support to kvm_hypercall() > is a logically independent change. >
I see what you mean. Will split this change into two in the next series.
> > ... > > > > -- > > > > 2.37.2.789.g6183377224-goog > > > >
| |