Messages in this thread | | | From | Vishal Annapurve <> | Date | Mon, 26 Sep 2022 16:35:54 -0700 | Subject | Re: [V2 PATCH 7/8] Kvm: selftests: x86: Execute cpu specific vmcall instruction |
| |
On Wed, Sep 21, 2022 at 2:43 PM David Matlack <dmatlack@google.com> wrote: > > On Thu, Sep 15, 2022 at 12:04:47AM +0000, Vishal Annapurve wrote: > > Update the vmcall instruction invocation to happen according to the cpu > > type. > > > > Suggested-by: Sean Christopherson <seanjc@google.com> > > Signed-off-by: Vishal Annapurve <vannapurve@google.com> > > --- > > tools/testing/selftests/kvm/include/x86_64/processor.h | 8 ++++++++ > > tools/testing/selftests/kvm/x86_64/vmx_apic_access_test.c | 2 +- > > .../selftests/kvm/x86_64/vmx_nested_tsc_scaling_test.c | 2 +- > > tools/testing/selftests/kvm/x86_64/vmx_tsc_adjust_test.c | 2 +- > > What's the reason to use kvm_hypercall() for these tests? All of these > are Intel-specific. i.e. is_amd_cpu() will always return false. >
That's right. This change is attempting to have hypercalls from guest code done via a common API as far as possible.
> > 4 files changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h > > ... > > -- > > 2.37.2.789.g6183377224-goog > >
| |