Messages in this thread | | | From | Han Jingoo <> | Date | Mon, 26 Sep 2022 11:49:30 -0700 | Subject | Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf() |
| |
On Mon, Sep 26, 2022 Daniel Thompson <daniel.thompson@linaro.org> wrote: > > On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@gmail.com wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > > > Replace the open-code with sysfs_emit() to simplify the code. > > > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > > --- > > drivers/video/backlight/lp8788_bl.c | 2 +- > > This one has the subject right and is a good change. However I'd still > prefer it as a single patchset that fixes *all* instances of this code > pattern.
Yes, I agree with Daniel's opinion.
Xingchen, Please make a "Single" patch for including "ALL" fixes for this pattern in the 'drivers/video/backlight' directory. Thank you.
Best regards, Jingoo Han
> > > Daniel.
| |