Messages in this thread | | | Date | Mon, 26 Sep 2022 13:56:58 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations |
| |
On Mon, Sep 26, 2022 at 01:56:27PM +0300, Andy Shevchenko wrote: > On Fri, Sep 23, 2022 at 12:03:00PM -0700, Dmitry Torokhov wrote: > > On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote: > > > When the data structure is only referred by pointer, compiler may not need > > > to see the contents of the data type. Thus, we may replace header inclusions > > > by respective forward declarations.
...
> > > +struct device; > > > +struct input_dev; > > > > This results in a ton of compile errors. While I believe this change is > > a good one, we need to fix users of this include first. > > Indeed, sorry for breaking things (I compile-tested with limited drivers > enabled). I will look into LKP reports and will fix the users.
Ah, thanks, I see your series for that!
-- With Best Regards, Andy Shevchenko
| |