Messages in this thread | | | Date | Sat, 24 Sep 2022 23:17:58 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.4 2/5] gpio: ixp4xx: Make irqchip immutable |
| |
On Wed, Sep 21, 2022 at 10:04:27PM +0200, Bartosz Golaszewski wrote: >On Wed, Sep 21, 2022 at 6:57 PM Marc Zyngier <maz@kernel.org> wrote: >> >> On 2022-09-21 16:54, Sasha Levin wrote: >> > From: Linus Walleij <linus.walleij@linaro.org> >> > >> > [ Upstream commit 94e9bc73d85aa6ecfe249e985ff57abe0ab35f34 ] >> > >> > This turns the IXP4xx GPIO irqchip into an immutable >> > irqchip, a bit different from the standard template due >> > to being hierarchical. >> > >> > Tested on the IXP4xx which uses drivers/ata/pata_ixp4xx_cf.c >> > for a rootfs on compact flash with IRQs from this GPIO >> > block to the CF ATA controller. >> > >> > Cc: Marc Zyngier <maz@kernel.org> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> >> > Acked-by: Marc Zyngier <maz@kernel.org> >> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> >> > Signed-off-by: Sasha Levin <sashal@kernel.org> >> >> Why? The required dependencies are only in 5,19, and are >> definitely NOT a stable candidate... >> >> This isn't a fix by any stretch of the imagination. >> > >Hi Marc, > >While I didn't mark it for stable (and it shouldn't go into any branch >earlier than 5.19.x), I did send the patches making the irqchips >immutable to Linus Torvalds as fixes as they technically do *fix* the >warning emitted by gpiolib and make the implementation correct. > >I think these patches should still be part of the v5.19.x stable branch.
Yes, and as far as I see we are taking those fixes too.
-- Thanks, Sasha
| |