Messages in this thread | | | From | Marcin Wojtas <> | Date | Sat, 24 Sep 2022 08:44:28 +0200 | Subject | Re: [net-next PATCH] dt-bindings: net: marvell,pp2: convert to json-schema |
| |
Hi,
Thank you for the patch.
> + > +properties: > + > + dma-coherent: true > + > + compatible: > + enum: > + - marvell,armada-375-pp2 > + - marvell,armada-7k-pp2
I double checked with armada-cp11x.dtsi and the driver. Please s/marvell,armada-7k-pp2/marvell,armada-7k-pp22/ in all occurrences.
> + > + reg: > + minItems: 3 > + maxItems: 4 > + > +examples: > + - | > + // For Armada 375 variant > + #include <dt-bindings/interrupt-controller/mvebu-icu.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + ethernet@f0000 { > + interrupt-controller; > + #interrupt-cells = <3>;
interrupt-controller and #interrupt-cells are not valid properties for this controller.
> + compatible = "marvell,armada-375-pp2"; > + reg = <0xf0000 0xa000>, > + <0xc0000 0x3060>, > + <0xc4000 0x100>, > + <0xc5000 0x100>; > + clocks = <&gateclk 3>, <&gateclk 19>; > + #address-cells = <1>; > + #size-cells = <0>; > + clock-names = "pp_clk", "gop_clk"; > + > + eth0: eth0@c4000 { > + reg = <0xc4000>; > + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; > + port-id = <0>; > + phy = <&phy0>; > + phy-mode = "gmii"; > + }; > + > + eth1: eth1@c5000 { > + reg = <0xc5000>; > + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; > + port-id = <1>; > + phy = <&phy3>; > + phy-mode = "gmii"; > + }; > + }; > + > + - | > + // For Armada 7k/8k and Cn913x variants > + #include <dt-bindings/interrupt-controller/mvebu-icu.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + cpm_ethernet: ethernet@0 { > + interrupt-controller; > + #interrupt-cells = <3>;
interrupt-controller and #interrupt-cells are not valid properties for this controller.
Best regards, Marcin
| |