Messages in this thread | | | Date | Fri, 23 Sep 2022 19:26:29 +0200 | Subject | Re: [PATCH v8 7/7] remoteproc: qcom: Add support for memory sandbox | From | Krzysztof Kozlowski <> |
| |
On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote: > Update pil driver with SMMU mapping for allowing authorised > memory access to ADSP firmware, by carveout reserved adsp memory > region from device tree file. >
Thank you for your patch. There is something to discuss/improve.
> + if (!rproc->domain) > + return -EINVAL; > + > + ret = of_parse_phandle_with_args(adsp->dev->of_node, "iommus", "#iommu-cells", 0, &args);
I think your bindings do not allow iommus property.
Best regards, Krzysztof
| |