Messages in this thread | | | Date | Fri, 23 Sep 2022 08:17:26 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime |
| |
On Thu, Sep 22, 2022 at 12:55:03PM -0700, Kuogee Hsieh wrote: > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Device-managed resources allocated post component bind must be tied to > > the lifetime of the aggregate DRM device or they will not necessarily be > > released when binding of the aggregate device is deferred. > > > > This is specifically true for the HDMI IRQ, which will otherwise remain > > requested so that the next bind attempt fails when requesting the IRQ a > > second time. > > > > Fix this by tying the device-managed lifetime of the HDMI IRQ to the DRM > > device so that it is released when bind fails. > > > > Fixes: 067fef372c73 ("drm/msm/hdmi: refactor bind/init") > > Cc: stable@vger.kernel.org # 3.19 > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > > Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > > Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
I believe you meant:
Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
here (i.e. without the '>' quotes). Otherwise the tooling may not pick these up.
Thanks for reviewing and testing.
Johan
| |