| Date | Fri, 23 Sep 2022 13:13:12 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 03/25] rseq: Extend struct rseq with numa node id |
| |
On Thu, Sep 22, 2022 at 06:59:18AM -0400, Mathieu Desnoyers wrote: > diff --git a/include/trace/events/rseq.h b/include/trace/events/rseq.h > index a04a64bc1a00..6bd442697354 100644 > --- a/include/trace/events/rseq.h > +++ b/include/trace/events/rseq.h > @@ -16,13 +16,15 @@ TRACE_EVENT(rseq_update, > > TP_STRUCT__entry( > __field(s32, cpu_id) > + __field(s32, node_id) > ), > > TP_fast_assign( > __entry->cpu_id = raw_smp_processor_id(); > + __entry->node_id = cpu_to_node(raw_smp_processor_id());
Very minor nit: perhaps:
_entry->node_id = cpu_to_node(__entry->cpu_id);
just in case it does a reload and finds a different value.
> ),
|