Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 22 Sep 2022 09:34:44 -0700 | Subject | Re: [PATCH v4 3/4] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip |
| |
Hi,
On Thu, Sep 22, 2022 at 3:23 AM Yunlong Jia <ecs.beijing2022@gmail.com> wrote: > > Add an elan touch screen chip eth3915n. > > Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
You should have left my Reviewed-by off in this case. I haven't actually seen this patch. You could have possibly added "Suggested-by" or just left me off entirely until I gave you the tag.
> --- > > (no changes since v1)
I probably would have added this in patman:
Series-changes: 4 - eth3915n dt bindings added in v4.
Without that you get the "(no changes from v1)" which is always weird since this patch is new for v4.
> .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml > index a9b53c2e6f0ab..d28625372f5ac 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml > @@ -17,6 +17,7 @@ properties: > enum: > - elan,ektf3624 > - elan,ekth3500 > + - elan,ekth3915
This is not quite right because for elan,ekth3915 you're expecting device trees to have:
compatible = "elan,ekth3915", "elan,ekth3500"
In other words it's actually a 3915 but the 3500 driver should work fine. I believe a reasonable syntax is:
compatible: oneOf: - enum: - elan,ektf3624 - elan,ekth3500 - items: - const: elan,ekth3915 - const: elan,ekth3500
-Doug
| |