Messages in this thread | | | Date | Thu, 22 Sep 2022 15:04:07 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v3 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions |
| |
On Thu, Sep 01, 2022 at 02:26:56PM +0100, James Clark wrote: > I'm resubmitting this with a few of the changes suggested by Will on V2. > > I haven't made any changes regarding the open questions about the > discoverability or saving the new reg and passing to output_sample() > because I think it's best to be consistent with the implementations on > other platforms first. I have explained in more detail on v2 [1]. > > [1]: https://lore.kernel.org/lkml/5fcf1a6f-c8fb-c296-992e-18aae8874095@arm.com/
Fair enough, I can't argue against being consistent.
Given that this exposes subtle new user ABI, do we have any coverage in the selftests? If not, please could you add something?
Thanks,
Will
| |