| Date | Thu, 22 Sep 2022 09:24:26 +0200 | Subject | Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support | From | Krzysztof Kozlowski <> |
| |
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi");
That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle.
Best regards, Krzysztof
|