Messages in this thread | | | From | Li Zhong <> | Date | Wed, 21 Sep 2022 01:31:06 -0700 | Subject | Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start() |
| |
On Tue, Sep 20, 2022 at 12:41 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 20 Sep 2022 12:31:29 -0700 Li Zhong wrote: > > On Tue, Sep 20, 2022 at 11:37 AM Jakub Kicinski <kuba@kernel.org> wrote: > > > On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote: > > > > goto err_cancel_table; > > > > > > > > entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY); > > > > + if (!entry) > > > > + return -EMSGSIZE; > > > > > > not even correct, and completely harmless > > > > Thanks for your reply. Maybe a more suitable way of error handling is 'goto > > err_cancel_table;'? > > Yes, but you _most_ provide the detailed analysis of the impact > in the commit message for the patches to be considered for merging.
Thanks for the suggestion. The commit message is updated with more details.
| |