Messages in this thread | | | Date | Wed, 21 Sep 2022 10:24:04 +0200 | Subject | Re: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property | From | Krzysztof Kozlowski <> |
| |
On 21/09/2022 09:07, Jianguo Zhang wrote: > Add clk_csr property for snps,dwmac > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 491597c02edf..8cff30a8125d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -288,6 +288,11 @@ properties: > is supported. For example, this is used in case of SGMII and > MAC2MAC connection. > > + clk_csr:
No underscores in node names. Missing vendor prefix.
> + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Frequency division factor for MDC clock.
Can't common clock framework do the job? What is the MDC clock?
Best regards, Krzysztof
| |