lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/2] dt-bindings: net: snps,dwmac: add clk_csr property
From
On 21/09/2022 09:07, Jianguo Zhang wrote:
> Add clk_csr property for snps,dwmac
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 491597c02edf..8cff30a8125d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -288,6 +288,11 @@ properties:
> is supported. For example, this is used in case of SGMII and
> MAC2MAC connection.
>
> + clk_csr:

No underscores in node names. Missing vendor prefix.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Frequency division factor for MDC clock.

Can't common clock framework do the job? What is the MDC clock?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-21 10:25    [W:0.071 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site