Messages in this thread | | | Date | Tue, 20 Sep 2022 14:27:20 +0530 | Subject | Re: [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes | From | Bhupesh Sharma <> |
| |
On 9/20/22 12:55 PM, Krzysztof Kozlowski wrote: > On 20/09/2022 00:15, Bhupesh Sharma wrote: >> Since we are using soc specific qce crypto IP compatibles >> in the bindings now, use the same in the device tree files >> which include the crypto nodes. >> >> Cc: Bjorn Andersson <andersson@kernel.org> >> Cc: Rob Herring <robh@kernel.org> >> Tested-by: Jordan Crouse <jorcrous@amazon.com> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> --- >> arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- >> 5 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi >> index b23591110bd2..9c40714562d5 100644 >> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi >> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi >> @@ -314,7 +314,7 @@ cryptobam: dma-controller@8e04000 { >> }; >> >> crypto: crypto@8e3a000 { >> - compatible = "qcom,crypto-v5.1"; >> + compatible = "qcom,ipq4019-qce"; > > There are few issues here: > 1. Compatible is not documented.
Its documented here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/
[as mentioned in the dependency section in the cover letter :)]
> 2. Compatible is not supported by old kernel - ABI break. > 3. Everything won't be bisectable...
I think its a question of dependencies b/w the patchsets intended for separate areas. Let me think more on how, I can resolve it in newer versions.
Thanks, Bhupesh
> The same in other places. > > Best regards, > Krzysztof
| |