Messages in this thread | | | Date | Tue, 20 Sep 2022 09:25:50 +0200 | Subject | Re: [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes | From | Krzysztof Kozlowski <> |
| |
On 20/09/2022 00:15, Bhupesh Sharma wrote: > Since we are using soc specific qce crypto IP compatibles > in the bindings now, use the same in the device tree files > which include the crypto nodes. > > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Rob Herring <robh@kernel.org> > Tested-by: Jordan Crouse <jorcrous@amazon.com> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi > index b23591110bd2..9c40714562d5 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi > @@ -314,7 +314,7 @@ cryptobam: dma-controller@8e04000 { > }; > > crypto: crypto@8e3a000 { > - compatible = "qcom,crypto-v5.1"; > + compatible = "qcom,ipq4019-qce";
There are few issues here: 1. Compatible is not documented. 2. Compatible is not supported by old kernel - ABI break. 3. Everything won't be bisectable...
The same in other places.
Best regards, Krzysztof
| |