lkml.org 
[lkml]   [2022]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 1/5] PCI: qcom: Add system suspend and resume support
From
On 9/20/2022 3:22 AM, Krishna chaitanya chundru wrote:
> Add suspend and resume syscore ops.
>
> Few PCIe endpoints like NVMe and WLANs are always expecting the device
> to be in D0 state and the link to be active (or in l1ss) all the time
> (including in S3 state).
>
> In qcom platform PCIe resources( clocks, phy etc..) can released

can *be* released... ??

> when the link is in L1ss to reduce the power consumption. So if the link
> is in L1ss, release the PCIe resources. And when the system resumes,
> enable the PCIe resources if they released in the suspend path.

if they *were* released... ??

>
> is_suspended flag indicates if the PCIe resources are released or not
> in the suspend path.
>
> Its observed that access to Ep PCIe space to mask MSI/MSIX is happening

s/Its/It's/

> at the very late stage of suspend path (access by affinity changes while
> making CPUs offline during suspend, this will happen after devices are
> suspended (after all phases of suspend ops)). If we turn off clocks in

All those parenthesis, thought I was reading Lisp.
Can you rewrite in conversational English?

\
 
 \ /
  Last update: 2022-09-21 00:00    [W:0.147 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site