Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 20 Sep 2022 14:47:05 -0700 | Subject | Re: [PATCH v2 2/2] perf test: Introduce script for java symbol testing |
| |
Hi Leo,
On Sat, Sep 17, 2022 at 8:15 PM Leo Yan <leo.yan@linaro.org> wrote: > > This commit introduces a script for testing java symbols. > > The test records java program, inject samples with JIT samples, check > specific JIT symbols in the report, the test will pass only when these > two symbols are detected. > > Suggested-by: Ian Rogers <irogers@google.com> > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/tests/shell/test_java_symbol.sh | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100755 tools/perf/tests/shell/test_java_symbol.sh > > diff --git a/tools/perf/tests/shell/test_java_symbol.sh b/tools/perf/tests/shell/test_java_symbol.sh > new file mode 100755 > index 000000000000..d96fea405ea9 > --- /dev/null > +++ b/tools/perf/tests/shell/test_java_symbol.sh > @@ -0,0 +1,69 @@ > +#!/bin/bash > +# Test java symbol > + > +# SPDX-License-Identifier: GPL-2.0 > +# Leo Yan <leo.yan@linaro.org>, 2022 > + > +PERF_DATA=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > +PERF_INJ_DATA=$(mktemp /tmp/__perf_test.perf.data.inj.XXXXX) > + > +cleanup_files() > +{ > + echo "Cleaning up files..." > + rm -f ${PERF_DATA} > + rm -f ${PERF_INJ_DATA} > +} > + > +trap cleanup_files exit term int > + > +if [ -e "$PWD/tools/perf/libperf-jvmti.so" ]; then > + LIBJVMTI=$PWD/tools/perf/libperf-jvmti.so > +elif [ -e "$PWD/libperf-jvmti.so" ]; then > + LIBJVMTI=$PWD/libperf-jvmti.so > +elif [ -e "$PREFIX/lib64/libperf-jvmti.so" ]; then > + LIBJVMTI=$PREFIX/lib64/libperf-jvmti.so > +elif [ -e "$PREFIX/lib/libperf-jvmti.so" ]; then > + LIBJVMTI=$PREFIX/lib/libperf-jvmti.so > +if [ -e "/usr/lib/linux-tools-$(uname -a | awk '{ print $3 }' | sed -r 's/-generic//')/libperf-jvmti.so" ]; then
s/if/elif/ ?
> + LIBJVMTI=/usr/lib/linux-tools-$(uname -a | awk '{ print $3 }' | sed -r 's/-generic//')/libperf-jvmti.so > +else > + echo "Fail to find libperf-jvmti.so" > + # JVMTI is a build option, skip the test if fail to find lib > + exit 2 > +fi > + > +cat <<EOF | perf record -k 1 -o $PERF_DATA jshell -s -J-agentpath:$LIBJVMTI
Wouldn't it check if jshell is available first?
Thanks, Namhyung
> +int fib(int x) { > + return x > 1 ? fib(x - 2) + fib(x - 1) : 1; > +} > + > +int q = 0; > + > +for (int i = 0; i < 10; i++) > + q += fib(i); > + > +System.out.println(q); > +EOF > + > +if [ $? -ne 0 ]; then > + echo "Fail to record for java program" > + exit 1 > +fi > + > +if ! perf inject -i $PERF_DATA -o $PERF_INJ_DATA -j; then > + echo "Fail to inject samples" > + exit 1 > +fi > + > +# Below is an example of the instruction samples reporting: > +# 8.18% jshell jitted-50116-29.so [.] Interpreter > +# 0.75% Thread-1 jitted-83602-1670.so [.] jdk.internal.jimage.BasicImageReader.getString(int) > +perf report --stdio -i ${PERF_INJ_DATA} 2>&1 | \ > + egrep " +[0-9]+\.[0-9]+% .* (Interpreter|jdk\.internal).*" > /dev/null 2>&1 > + > +if [ $? -ne 0 ]; then > + echo "Fail to find java symbols" > + exit 1 > +fi > + > +exit 0 > -- > 2.34.1 >
| |