lkml.org 
[lkml]   [2022]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warning after merge of the libata tree
Hello Damien

On Tue, Sep 20, 2022 at 08:56:53AM +0900, Damien Le Moal wrote:
> On 9/19/22 11:40, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the libata tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> > drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
> > 147 | struct device *dev = &pdev->dev;
> > | ^~~
> >
> > Introduced by commit
> >
> > 3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")
> >
>

> I pushed a fix for this. I also added a dependency on COMPILE_TEST for
> this driver to avoid a repeat in the future.

I'm sorry for not delivering a quick response to the request. Thanks
for sending the fix. Indeed the dev variable should have been dropped.
I should have checked that after removing a part of the code some
variables could be left unused.

-Sergey

>
> Thanks.
>
> --
> Damien Le Moal
> Western Digital Research
>

\
 
 \ /
  Last update: 2022-09-20 22:54    [W:0.138 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site