Messages in this thread | | | Subject | Re: [PATCH] net: sh_eth: Fix PHY state warning splat during system resume | From | Sergey Shtylyov <> | Date | Mon, 19 Sep 2022 21:43:15 +0300 |
| |
On 9/19/22 5:48 PM, Geert Uytterhoeven wrote:
> Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect > mdio_bus_phy_resume() state"), a warning splat is printed during system > resume with Wake-on-LAN disabled: > > WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4 > > As the Renesas SuperH Ethernet driver already calls phy_{stop,start}() > in its suspend/resume callbacks, it is sufficient to just mark the MAC > responsible for managing the power state of the PHY. > > Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 67ade78fb7671c4a..7fd8828d3a846169 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2029,6 +2029,8 @@ static int sh_eth_phy_init(struct net_device *ndev) > if (mdp->cd->register_type != SH_ETH_REG_GIGABIT) > phy_set_max_speed(phydev, SPEED_100); > > + /* Indicate that the MAC is responsible for managing PHY PM */
Again, this field is declared as *unsigned*...
> + phydev->mac_managed_pm = true; > phy_attached_info(phydev); [...]
MBR, Sergey
| |