lkml.org 
[lkml]   [2022]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] cpufreq: tegra239: Add support for T239
On Mon, Sep 05, 2022 at 09:27:59PM +0530, Sumit Gupta wrote:
> Adding support for Tegra239 SoC which has eight cores in
> a single cluster. Also, moving num_clusters to soc data

Found two more minor things: s/soc/SoC/ for consistent spelling.

> to avoid over allocating memory for four clusters always.
>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> drivers/cpufreq/tegra194-cpufreq.c | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 1216046cf4c2..f38a760da61b 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -38,14 +38,6 @@
> /* cpufreq transisition latency */
> #define TEGRA_CPUFREQ_TRANSITION_LATENCY (300 * 1000) /* unit in nanoseconds */
>
> -enum cluster {
> - CLUSTER0,
> - CLUSTER1,
> - CLUSTER2,
> - CLUSTER3,
> - MAX_CLUSTERS,
> -};
> -
> struct tegra_cpu_ctr {
> u32 cpu;
> u32 coreclk_cnt, last_coreclk_cnt;
> @@ -67,12 +59,12 @@ struct tegra_cpufreq_ops {
> struct tegra_cpufreq_soc {
> struct tegra_cpufreq_ops *ops;
> int maxcpus_per_cluster;
> + size_t num_clusters;

Might want to make this unsigned int while at it. size_t is preferred
for things that actually refer to the size of something, while this is a
count, so unsigned int fits slightly better. It's admittedly a bit
pedantic...

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-09-15 14:23    [W:0.108 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site